haythemkh commented on PR #943: URL: https://github.com/apache/solr/pull/943#issuecomment-1201380445
I would love to have your feedback on what we want to do with the nocommits: - These include copying ZkStateReader constants for solrj classes: [Utils](https://github.com/apache/solr/blob/521900d77ac938ba98a237fc1ca77700b168714d/solr/solrj/src/java/org/apache/solr/common/util/Utils.java#L89), [PerReplicaStates](https://github.com/apache/solr/blob/521900d77ac938ba98a237fc1ca77700b168714d/solr/solrj/src/java/org/apache/solr/common/cloud/PerReplicaStates.java#L182), [ClusterState](https://github.com/apache/solr/blob/521900d77ac938ba98a237fc1ca77700b168714d/solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java#L49), [DocCollection](https://github.com/apache/solr/blob/521900d77ac938ba98a237fc1ca77700b168714d/solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java#L44), [Slice](https://github.com/apache/solr/blob/521900d77ac938ba98a237fc1ca77700b168714d/solr/solrj/src/java/org/apache/solr/common/cloud/Slice.java#L46), [Replica](https://github.com/apache/solr/blob/521900d77ac938ba98a237fc1ca77700b168714d/solr/solrj/src/java/org/apache/sol r/common/cloud/Replica.java#L41), [ZkCoreNodeProps](https://github.com/apache/solr/blob/521900d77ac938ba98a237fc1ca77700b168714d/solr/solrj/src/java/org/apache/solr/common/cloud/ZkCoreNodeProps.java#L23), [CloudSolrClient](https://github.com/apache/solr/blob/521900d77ac938ba98a237fc1ca77700b168714d/solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java#L93), [BaseHttpClusterStateProvider](https://github.com/apache/solr/blob/521900d77ac938ba98a237fc1ca77700b168714d/solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java#L48), [CollectionAdminRequest](https://github.com/apache/solr/blob/521900d77ac938ba98a237fc1ca77700b168714d/solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java#L73), [CoreAdminRequest](https://github.com/apache/solr/blob/521900d77ac938ba98a237fc1ca77700b168714d/solr/solrj/src/java/org/apache/solr/client/solrj/request/CoreAdminRequest.java#L40) - [Use raw "http" instead of going through #getClusterProperty in DatabaseMetaDataImpl](https://github.com/apache/solr/blob/521900d77ac938ba98a237fc1ca77700b168714d/solr/solrj/src/java/org/apache/solr/client/solrj/io/sql/DatabaseMetaDataImpl.java#L123) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
