HoustonPutman commented on PR #943: URL: https://github.com/apache/solr/pull/943#issuecomment-1206637357
> [PerReplicaStates](https://github.com/apache/solr/blob/521900d77ac938ba98a237fc1ca77700b168714d/solr/solrj/src/java/org/apache/solr/common/cloud/PerReplicaStates.java#L182) Is there any reason for PRS not to be in the zk module? I don't think it would be used if we aren't communicating with ZK. > Copy of ZkStateReader constants to solrj classes Would it make more sense to have one `ClusterStateProps` class to hold these? We could also split it into `ClusterProps`, `CollectionProps`, etc, but that might be overkill. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
