anshumg commented on code in PR #32:
URL: https://github.com/apache/solr-sandbox/pull/32#discussion_r935944295
##########
crossdc-consumer/src/main/java/org/apache/solr/crossdc/consumer/KafkaCrossDcConsumer.java:
##########
@@ -49,7 +49,7 @@ public KafkaCrossDcConsumer(KafkaCrossDcConf conf) {
kafkaConsumerProp.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG,
conf.getBootStrapServers());
- kafkaConsumerProp.put(ConsumerConfig.GROUP_ID_CONFIG, "group_1"); // TODO
+ kafkaConsumerProp.put(ConsumerConfig.GROUP_ID_CONFIG, conf.getGroupId());
// TODO
Review Comment:
We can get rid of the `//TODO` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
