markrmiller commented on PR #32: URL: https://github.com/apache/solr-sandbox/pull/32#issuecomment-1205865580
> We need to handle empty/malformed/missing groupId, topicName, etc. here. Do we? That means copying and duplicating and evolving the rules from/with Kafka when Kafka already handles it for us. We pass the input to Kafka, it validates it, it spits out an error message. > I personally feel it doesn't make sense to have a default but I'm open to a counter argument. The counter is that it's required to pass a group id so you need some default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
