markrmiller commented on PR #32: URL: https://github.com/apache/solr-sandbox/pull/32#issuecomment-1205871709
Okay, I was reading that as kind of two different comments, and it just jelled for me. You are saying you think we should make groupid required in our config? I guess I would say that feels a little unnecessary given it doesn't necessarily always have value for a setup and if it does a user would know that they want that value and be able to use it, and someone trying things out or that didn't need it wouldn't have to add one more bit of config that they may or may not understand initially. To pick a reasonable group id, you really have to understand something about Kafka and what it is and if you understand that you know whether you want a group id or not and if you don't know all that, it's just a seemingly not very relevant addition to the current very simple required config for someone getting started. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
