risdenk commented on code in PR #953:
URL: https://github.com/apache/solr/pull/953#discussion_r998697932
##########
solr/core/src/test/org/apache/solr/handler/ReplicationTestHelper.java:
##########
@@ -111,7 +108,7 @@ public static void assertVersions(SolrClient client1,
SolrClient client2) throws
Long maxVersionClient2 = getVersion(client2);
if (maxVersionClient1 > 0 && maxVersionClient2 > 0) {
- assertEquals(maxVersionClient1, maxVersionClient2);
+ SolrTestCaseJ4.assertEquals(maxVersionClient1, maxVersionClient2);
Review Comment:
This is the JUnit one technically. It avoids the extra import and shows it
comes through the underlying class heirarchy. LuceneTestCase extends Assert
##########
solr/core/src/test/org/apache/solr/handler/TestSampleDocumentsLoader.java:
##########
@@ -40,7 +35,7 @@
import org.junit.Before;
import org.junit.Test;
-public class TestSampleDocumentsLoader {
+public class TestSampleDocumentsLoader extends SolrTestCase {
Review Comment:
Get all the benefits of the underlying randomization and thread leak checks
from Lucene. This ensures that all these tests have a common base. There are no
real downsides to doing this either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
