risdenk commented on code in PR #953:
URL: https://github.com/apache/solr/pull/953#discussion_r998698569
##########
solr/core/src/test/org/apache/solr/handler/component/SpellCheckComponentTest.java:
##########
@@ -627,8 +627,8 @@ public void testThresholdTokenFrequency() throws Exception {
NamedList<?> values = rsp.getValues();
NamedList<?> spellCheck = (NamedList<?>) values.get("spellcheck");
NamedList<?> suggestions = (NamedList<?>) spellCheck.get("suggestions");
- assertTrue(suggestions.get("suggestion") == null);
- assertTrue((Boolean) spellCheck.get("correctlySpelled") == false);
+ assertNull(suggestions.get("suggestion"));
+ assertFalse((boolean) (Boolean) spellCheck.get("correctlySpelled"));
Review Comment:
agreed will fix.
##########
solr/core/src/test/org/apache/solr/handler/component/SpellCheckComponentTest.java:
##########
@@ -640,7 +640,7 @@ public void testThresholdTokenFrequency() throws Exception {
values = rsp.getValues();
spellCheck = (NamedList<?>) values.get("spellcheck");
suggestions = (NamedList<?>) spellCheck.get("suggestions");
- assertTrue(suggestions.get("suggestion") == null);
- assertTrue((Boolean) spellCheck.get("correctlySpelled") == false);
+ assertNull(suggestions.get("suggestion"));
+ assertFalse((boolean) (Boolean) spellCheck.get("correctlySpelled"));
Review Comment:
agreed will fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
