risdenk commented on code in PR #953:
URL: https://github.com/apache/solr/pull/953#discussion_r998700173
##########
solr/modules/langid/src/test/org/apache/solr/update/processor/SolrInputDocumentReaderTest.java:
##########
@@ -16,21 +16,19 @@
*/
package org.apache.solr.update.processor;
-import static org.junit.Assert.assertArrayEquals;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
-
import java.util.Arrays;
+import org.apache.solr.SolrTestCase;
import org.apache.solr.common.SolrInputDocument;
import org.junit.Before;
import org.junit.Test;
-public class SolrInputDocumentReaderTest {
+public class SolrInputDocumentReaderTest extends SolrTestCase {
Review Comment:
Get all the benefits of the underlying randomization and thread leak checks
from Lucene. This ensures that all these tests have a common base. There are no
real downsides to doing this either.
##########
solr/modules/analytics/src/test/org/apache/solr/analytics/legacy/facet/LegacyFieldFacetCloudTest.java:
##########
@@ -442,48 +440,48 @@ public void sumTest() throws Exception {
String responseStr = response.toString();
// Int Date
- Collection<Double> intDate =
+ ArrayList<Double> intDate =
Review Comment:
Probably, but the method actually returns an ArrayList itself. I didn't
change the method response. The reason it can't be a collection is that is
ambiguous when comparing assertEquals - errorprone catches this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
