risdenk commented on code in PR #1127: URL: https://github.com/apache/solr/pull/1127#discussion_r1004878560
########## solr/solrj/src/test/org/apache/solr/common/cloud/AliasesTest.java: ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.common.cloud; + +import java.util.List; +import java.util.Map; +import org.apache.solr.SolrTestCase; +import org.apache.solr.common.SolrException; + +/** Unit test for {@link Aliases} */ +public class AliasesTest extends SolrTestCase { + + public void testCloneWithRenameNullBefore() { + Aliases aliases = Aliases.EMPTY; + try { + aliases.cloneWithRename(null, "alias1"); Review Comment: `assertThrows` would be better for this test? ########## solr/solrj/src/test/org/apache/solr/common/cloud/AliasesTest.java: ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.common.cloud; + +import java.util.List; +import java.util.Map; +import org.apache.solr.SolrTestCase; +import org.apache.solr.common.SolrException; + +/** Unit test for {@link Aliases} */ +public class AliasesTest extends SolrTestCase { + + public void testCloneWithRenameNullBefore() { + Aliases aliases = Aliases.EMPTY; + try { + aliases.cloneWithRename(null, "alias1"); + fail("null value should not be allowed"); + } catch (SolrException e) { + assertEquals(SolrException.ErrorCode.BAD_REQUEST.code, e.code()); + } + } + + public void testCloneWithRenameEmptyBefore() { + Aliases aliases = Aliases.EMPTY; + try { + aliases.cloneWithRename("", "alias1"); + fail("null value should not be allowed"); + } catch (SolrException e) { + assertEquals(SolrException.ErrorCode.BAD_REQUEST.code, e.code()); + } + } + + public void testCloneWithRenameEmptyAfter() { + Aliases aliases = Aliases.EMPTY; + try { + aliases.cloneWithRename("alias0", ""); + fail("null value should not be allowed"); + } catch (SolrException e) { Review Comment: `assertThrows` would be better for this test? ########## solr/CHANGES.txt: ########## @@ -65,6 +65,8 @@ Optimizations Bug Fixes --------------------- +* SOLR-16477: Collection RENAME api creates broken alias Review Comment: nit: usually this goes at the bottom of the list. ########## solr/solrj/src/test/org/apache/solr/common/cloud/AliasesTest.java: ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.common.cloud; + +import java.util.List; +import java.util.Map; +import org.apache.solr.SolrTestCase; +import org.apache.solr.common.SolrException; + +/** Unit test for {@link Aliases} */ +public class AliasesTest extends SolrTestCase { + + public void testCloneWithRenameNullBefore() { + Aliases aliases = Aliases.EMPTY; + try { + aliases.cloneWithRename(null, "alias1"); + fail("null value should not be allowed"); + } catch (SolrException e) { + assertEquals(SolrException.ErrorCode.BAD_REQUEST.code, e.code()); + } + } + + public void testCloneWithRenameEmptyBefore() { + Aliases aliases = Aliases.EMPTY; + try { + aliases.cloneWithRename("", "alias1"); + fail("null value should not be allowed"); + } catch (SolrException e) { Review Comment: `assertThrows` would be better for this test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
