gerlowskija commented on PR #1127: URL: https://github.com/apache/solr/pull/1127#issuecomment-1291967379
> if the starting point for the stream is a Map<>, the 'merge keys' part where it checks for collisions(a, b) -> IllegalStateException would never be possible In this case, I think that's true - we're not really "mapping" the keys in the sense this method allows, we're just taking them unmodified from an existing Map. I can imagine cases where the merge/collection function would be necessary, but it looks redundant here to me 🤷 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
