risdenk commented on PR #1127:
URL: https://github.com/apache/solr/pull/1127#issuecomment-1292417417
> I avoided doing too much cleanup/refactoring outside of the reported bug,
but I can include this change as well in the PR.
Agreed makes sense, but I think in this case if you add a test case for
`SolrException e = assertThrows(SolrException.class, () ->
aliases.cloneWithRename("alias1", null));` you might trigger that other NPE
case? At least from a quick glance that seemed related to the other NPE test
case you added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
