[
https://issues.apache.org/jira/browse/SOLR-16498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626776#comment-17626776
]
Eric Pugh commented on SOLR-16498:
----------------------------------
For fun, I just changed the {{TestReplicationHandler}} to take the
{{{}JettySolrRunner{}}}, however I think conceptually I understand what a
{{SolrClient}} is, and why I would get a URL from it more then I understand
what a {{JettySolrRunner}} is. I could be splitting hairs here... However,
you do call out this specifically in your comment ;).
There are a bunch of other tests that do a cast to {{HttpSolrServer}} just for
the URL, and maybe they all have a JettySolrRunner we could use?
I honestly don't have a good overall picture of why things are the way they
are, and if they should stay that way, and have been kind of deferring to
[~dsmiley] vision for it...
> Tests need the URL from a SolrClient; don't require legacy clients
> ------------------------------------------------------------------
>
> Key: SOLR-16498
> URL: https://issues.apache.org/jira/browse/SOLR-16498
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Tests
> Reporter: David Smiley
> Priority: Major
> Labels: newdev
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> SOLR-16368 could not switch many tests away from some legacy/deprecated
> SolrClient classes because they were either getting the URL or Apache
> HttpClient instance out of the client. This issue aims to solve this so that
> our tests don't depend on a legacy client and don't depend on Apache
> HttpClient either. We would prefer a non-dependency approach using [Java
> 11's new
> HttpClient|https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/package-summary.html].
> And we need to figure out how to get the URL from the SolrClient in a more
> general way.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
