gerlowskija commented on PR #1115: URL: https://github.com/apache/solr/pull/1115#issuecomment-1303955756
Hi @joshgog - just wanted to summarize where we are on this. I think at this point you've addressed everything I (and Noble) brought up in review so far. Unless I'm missing something? I've pushed one tiny edit a few minutes ago to ensure that ReplaceNodeAPI doesn't add values to its 'remoteMessage' map if they're null, and some tests for that. But otherwise this looks good to me. I'll aim to run tests/'check' on this over the weekend and commit as long as you've done everything here you were looking to? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
