gerlowskija commented on PR #1115: URL: https://github.com/apache/solr/pull/1115#issuecomment-1305636871
Gonna hold off on merging this for now based on Houston's comment above... > can we take /commands out of the path for this? /replace alone is pretty self-explanatory. Happy to remove it if there's consensus, but `/commands` in the path serves a few functions, at least one of which is probably non-obvious: 1. `/commands` is there for better consistency. All over the place in the APIs we have this pattern of `/pluralCollectionName/singleInstance`, whether this be in the form of `/collections/techproducts`, or `/shards/shard1`, or `/fields/fieldName`. "Commands" helps us stay consistent with that pattern - for whatever that's worth. 2. Less-obvious, using `/commands` helps cut down on potential path ambiguity between command names and names of cores, collections, shards, etc. It's less of an issue with this API in particular, but consider how this plays out for commands on the `/cores` path. Without "commands" in the path, each command name is a potential collision with a core name specified by a user. That is: `/api/cores/swap` becomes ambiguous: is a user attempting to swap two cores, or fetch the status of a core called 'swap'. Anyway, if neither of that sways you @HoustonPutman or @dsmiley , then we can update the API here and others in the spreadsheet more broadly. But figured i'd make a last defense of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
