gerlowskija commented on PR #1115:
URL: https://github.com/apache/solr/pull/1115#issuecomment-1305947078

   > the `nodes/SingleNode` is already there, so we are still following this 
consistency.
   
   Doing it for nodes and not commands or other things is the definition of 
inconsistency 😛 
   
   We follow it here for the node-name, yes.  But the idea isn't to do this 
once-per-path and call it a day, it's to do it everywhere we expose a noun or 
resource in our API paths.  The consistency of design across APIs is what helps 
users reason about what an API will likely be for some operation they're 
unfamiliar with.  If a user is familiar with other APIs and has seen Solr use 
this pattern for nodes, collections, cores, shards, replicas, replica 
properties, cluster properties, fields, fieldTypes, requestHandlers, and on and 
on .... well then they'll probably expect something similar here.
   
   
   IMO, The question shouldn't be whether we can get by without this in the 
path.  The question should be: what does omitting `/commands` get us that makes 
taking the hit on consistency worth it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to