epugh opened a new pull request, #1211: URL: https://github.com/apache/solr/pull/1211
https://issues.apache.org/jira/browse/SOLR-8975 Please note, this was originally https://github.com/apache/solr/pull/1158, however we had a different JIRA open that more accurately reflected this work. So I closed and reopened a new branch. # Description Now that builders are in place for SolrClients, the setters used in each SolrClient can be deprecated, and their functionality moved over to the Builders. This change brings a few benefits: * unifies SolrClient configuration under the new Builders. It'll be nice to have all the knobs, and levers used to tweak SolrClients available in a single place (the Builders). * reduces SolrClient thread-safety concerns. Currently, clients are mutable. Using some SolrClient setters can result in erratic and "trappy" behavior when the clients are used across multiple threads. Proposed Commit message is: ``` Introduce Builder Pattern with all Solr Clients ``` and ``` Deprecate all setters on Solr Clients, and introduce equivalents on the Builders. Migrate tests to using Builders. Use the try/with resources pattern when creating SolrClients in the tests. `` # Solution Added Builders where approapriate, and moved over tests to using the builders. Did not remove any of the deprecated code. And there are definitly some place still in the tests that need more work when we remove deprecated methods. # Tests ran the tests. # Checklist Please review the following and check all that apply: - [ x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x ] I have created a Jira issue and added the issue ID to my pull request title. - [ x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x ] I have developed this patch against the `main` branch. - [ x] I have run `./gradlew check`. - [ x] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
