epugh commented on code in PR #1211:
URL: https://github.com/apache/solr/pull/1211#discussion_r1039660985
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##########
@@ -62,6 +64,12 @@ protected CloudHttp2SolrClient(Builder builder) {
this.clientIsInternal = false;
this.myClient = builder.httpClient;
}
+ if (builder.requestWriter != null) {
+ this.myClient.setRequestWriter(builder.requestWriter); // should be part
of builder
Review Comment:
duh! I remember thinking "gosh darn it, something is off", and yes, you
are totally correct...! Doh!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
