epugh commented on code in PR #1211:
URL: https://github.com/apache/solr/pull/1211#discussion_r1039698417
##########
solr/solrj/src/test/org/apache/solr/client/solrj/SolrSchemalessExampleTest.java:
##########
@@ -132,20 +132,14 @@ public void testFieldMutating() throws Exception {
@Override
public SolrClient createNewSolrClient() {
- try {
- // setup the server...
- String url = jetty.getBaseUrl().toString() + "/collection1";
- HttpSolrClient client = getHttpSolrClient(url,
DEFAULT_CONNECTION_TIMEOUT);
- client.setUseMultiPartPost(random().nextBoolean());
-
- if (random().nextBoolean()) {
- client.setParser(new BinaryResponseParser());
- client.setRequestWriter(new BinaryRequestWriter());
- }
-
- return client;
- } catch (Exception ex) {
- throw new RuntimeException(ex);
+ HttpSolrClient.Builder httpSolrClientBuilder = new
HttpSolrClient.Builder(getServerUrl());
Review Comment:
getServerUrl definitly does assume collection1... I'd like, in the next
PR, to tackle the whole naming thing... When to use DEFAULT_TEST_CORENAME,
DEFAULT_TEST_COLLECTION_NAME... make both DEFAULTS_* have the same pattern...
CORENAME versus COLLECTION_NAME... and maybe rename getServerUrl to
soemthing else...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
