dsmiley commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1059849427
##########
solr/core/src/test-files/solr/solr.xml:
##########
@@ -35,11 +35,6 @@
<int name="connTimeout">${connTimeout:15000}</int>
</shardHandlerFactory>
- <transientCoreCacheFactory name="transientCoreCacheFactory"
class="TransientSolrCoreCacheFactoryDefault">
Review Comment:
?
This PR removes one "Factory" -- TransientCoreCacheFactory (the thing you
just referred to). I don't think it's needed at all. But it doesn't remove
TransientCoreCache, perhaps what you meant? Regardless, I think of this thing
as more of an implementation detail inside how the new TransientSolrCores
works. If you haven't reviewed this PR, please do before asking more questions.
I suspect your proposal is for there to be some abstraction that is
responsible for creating the cores _and_ managing/holding them generally. I
think it makes sense for "SolrCores" to be that abstraction. Maybe you didn't
mean one abstraction for both. I'm not sure it matters; maybe you should
propose something somewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
