noblepaul commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1062117703
##########
solr/core/src/test-files/solr/solr.xml:
##########
@@ -35,11 +35,6 @@
<int name="connTimeout">${connTimeout:15000}</int>
</shardHandlerFactory>
- <transientCoreCacheFactory name="transientCoreCacheFactory"
class="TransientSolrCoreCacheFactoryDefault">
Review Comment:
`SolrCores` is a concrete class . I'm against making a concrete class
pluggable. Lets start with an interface extracted from `SolrCores`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
