dsmiley commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1062644575
##########
solr/core/src/test-files/solr/solr.xml:
##########
@@ -35,11 +35,6 @@
<int name="connTimeout">${connTimeout:15000}</int>
</shardHandlerFactory>
- <transientCoreCacheFactory name="transientCoreCacheFactory"
class="TransientSolrCoreCacheFactoryDefault">
Review Comment:
I could imagine your asks of me snow-balling to fully documenting every
method. I'd like to remind the context as to why this JIRA issue exists and
its scope. Today there is too much complexity around this code relating to
transient cores -- a very niche feature that that is basically always enabled
even though almost nobody configures cores to be transient. I'm trying to
ensure that the typical code-path doesn't involve any transient core stuff, and
also not needlessly change APIs that don't need to change. In other words, do
a fairly narrow refactoring that is a positive step forward. I don't think
this should _require_ documenting existing things lacking documentation. Not
even splitting an interface honestly but I'll do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
