pvcnt opened a new pull request, #2016: URL: https://github.com/apache/solr/pull/2016
https://issues.apache.org/jira/browse/SOLR-15782 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description Currently, container-level plugins can only be declared installed via calls to /cluster/plugin APIs. In some situations (especially corporate ones having tight security requirements), it is not possible to mutate the configuration of a cluster at runtime. Cluster should rather be configured fully at startup, and any change in config requires a re-deployment. # Solution This PR makes it possible to declare container-level plugins in solr.xml. Those plugins will be installed when the system starts, and can later be updated/uninstalled using plugin APIs if needed. By design, the current implementation **works even in non-cloud installations**, which would allow to use container-level plugins in such situations. This raises two questions: * Do we envision having non-cloud container-level plugins, as this PR opens the way to? I am tempted to say it can be useful, but I don't know the original intention behind those plugins. * There is a mixed terminology of container plugins and cluster plugins, both in the docs and in the code. Related to my previous point, "container plugins" hints at the possibility of non-cloud plugins, while "cluster plugins" gets a rid of this hypothesis. # Tests Added a new test class for this. # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
