pvcnt commented on code in PR #2016:
URL: https://github.com/apache/solr/pull/2016#discussion_r1363841202
##########
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##########
@@ -154,7 +154,7 @@ private NodeConfig(
MetricsConfig metricsConfig,
Map<String, CacheConfig> cachesConfig,
PluginInfo tracerConfig,
- PluginInfo[] containerPlugins,
+ PluginInfo[] nodePlugins,
Review Comment:
As you said elsewhere, everything configured in `NodeConfig` is a plugin.
This introduces another kind of node-level plugin, which is more generic (as
depending on its shape it can be either a new request handler, a placement
plugin, etc.). Not sure how to name it honestly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
