pvcnt commented on code in PR #2016:
URL: https://github.com/apache/solr/pull/2016#discussion_r1363843267
##########
solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java:
##########
@@ -659,6 +660,17 @@ private static PluginInfo[]
getBackupRepositoryPluginInfos(List<ConfigNode> cfg)
return configs;
}
+ private static PluginInfo[] getNodePluginInfos(List<ConfigNode> cfg) {
+ if (cfg.isEmpty()) {
+ return new PluginInfo[0];
+ }
+ PluginInfo[] configs = new PluginInfo[cfg.size()];
+ for (int i = 0; i < cfg.size(); i++) {
+ configs[i] = new PluginInfo(cfg.get(i), "NodePlugin", true, true);
+ }
+ return configs;
+ }
Review Comment:
Sure, I copy/pasted this from elsewhere. 🙄
##########
solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java:
##########
@@ -659,6 +660,17 @@ private static PluginInfo[]
getBackupRepositoryPluginInfos(List<ConfigNode> cfg)
return configs;
}
+ private static PluginInfo[] getNodePluginInfos(List<ConfigNode> cfg) {
+ if (cfg.isEmpty()) {
+ return new PluginInfo[0];
+ }
+ PluginInfo[] configs = new PluginInfo[cfg.size()];
+ for (int i = 0; i < cfg.size(); i++) {
+ configs[i] = new PluginInfo(cfg.get(i), "NodePlugin", true, true);
+ }
+ return configs;
+ }
Review Comment:
Sure, I copy/pasted this from elsewhere. 🙄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]