[
https://issues.apache.org/jira/browse/SOLR-15782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775882#comment-17775882
]
David Smiley commented on SOLR-15782:
-------------------------------------
Perhaps a brief bike-shed on naming here. Can we say these are "node plugins"
and not use the words "container plugins"? Users know about a "Solr node", and
obviously we Solr hackers do too. I don't think the word "container" in the
context of Solr specifically means anything to our users. Of course, as deep
Solr hackers here, we know about CoreContainer and its name has become
unfortunate. I claim here we don't need to further that problem more than
necessary. The word "node" is a fine substitute. We have "NodeConfig" already
internally.
I searched for "container plugin" and only found a couple javadoc references
that could be changed. Also found a CHANGES.txt reference speaking of a
"container plugins API"; uh oh; what's that?
`org.apache.solr.handler.admin.ContainerPluginsApi` Okay; it's just a class
name; isn't in a user's consciousness necessarily. Looking at the EndPoint
annotations here, I see "/cluster/plugin" being referenced (not speaking of
either node or container). We've got a "cluster-plugins.adoc" file and it ,
well, is making references to CoreContainer although at least one spot it says
"(node)". Could be changed to be more node centric. Thoughts on this?
> Configure custom node/container handlers in solr.xml
> ----------------------------------------------------
>
> Key: SOLR-15782
> URL: https://issues.apache.org/jira/browse/SOLR-15782
> Project: Solr
> Issue Type: Improvement
> Reporter: David Smiley
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Since Solr 8.6 via SOLR-14404, it's been possible to define custom
> node/CoreContainer request handlers. However, the current mechanism requires
> the use of cluster properties (in ZooKeeper). That allows for dynamic
> registration (cool) but it's awkward to pre-define them – it doesn't comply
> with an [immutable
> infrastructure|https://www.bmc.com/blogs/immutable-infrastructure/] philosphy
> where node handlers can be defined by configuration local to the Solr node.
> That's solr.xml. So here, I propose that node handlers be defined there,
> perhaps the same as is done in solrconfig.xml.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
