pvcnt commented on code in PR #2016:
URL: https://github.com/apache/solr/pull/2016#discussion_r1360821830
##########
solr/core/src/test/org/apache/solr/api/ContainerPluginsRegistryTest.java:
##########
@@ -0,0 +1,105 @@
+package org.apache.solr.api;
+
+import java.nio.file.Path;
+import java.util.Map;
+import org.apache.solr.SolrTestCaseJ4;
+import org.apache.solr.cluster.placement.plugins.AffinityPlacementConfig;
+import org.apache.solr.core.CoreContainer;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+
+/** Tests for {@link ContainerPluginsRegistry} */
+public class ContainerPluginsRegistryTest extends SolrTestCaseJ4 {
Review Comment:
There is an existing `TestContainerPlugin` class that tests the same area of
code, but in a purely Solr Cloud context. Whether or not to merge both depends
on whether or not we want to go with cluster or container plugins imho.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
