pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1458616885
##########
solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java:
##########
@@ -88,31 +87,9 @@ public void startReplication(boolean switchTransactionLog) {
log.info("Will start replication from leader with poll interval: {}",
pollIntervalStr);
NamedList<Object> followerConfig = new NamedList<>();
- followerConfig.add("fetchFromLeader", Boolean.TRUE);
-
- // don't commit on leader version zero for PULL replicas as PULL should
only get its index
- // state from leader
- boolean skipCommitOnLeaderVersionZero = switchTransactionLog;
Review Comment:
When we are in this method, either we are a TLOG replica and
`switchTransactionLog` is true, hence `skipCommitOnLeaderVersionZero` is true,
or we are a PULL replica and `switchTransactionLog` is false but we force
`skipCommitOnLeaderVersionZero` to true below...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
