pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1458617284
##########
solr/core/src/java/org/apache/solr/cloud/ShardLeaderElectionContext.java:
##########
@@ -270,9 +270,11 @@ void runLeaderProcess(boolean weAreReplacement, int
pauseBeforeStart)
if (!isClosed) {
try {
- if (replicaType == Replica.Type.TLOG) {
+ if (replicaType.replicateFromLeader) {
// stop replicate from old leader
zkController.stopReplicationFromLeader(coreName);
+ }
+ if (replicaType == Replica.Type.TLOG) {
Review Comment:
Kept this reference to `Replica.Type`, it's not related to replication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
