pvcnt commented on code in PR #2207:
URL: https://github.com/apache/solr/pull/2207#discussion_r1489886455
##########
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##########
@@ -2400,15 +2402,15 @@ public void rejoinShardLeaderElection(SolrParams
params) {
try (SolrCore core = cc.getCore(coreName)) {
Replica.Type replicaType =
core.getCoreDescriptor().getCloudDescriptor().getReplicaType();
- if (replicaType == Type.TLOG) {
+ if (replicaType.replicateFromLeader) {
String leaderUrl =
getLeader(
core.getCoreDescriptor().getCloudDescriptor(),
cloudConfig.getLeaderVoteWait());
if (!leaderUrl.equals(ourUrl)) {
Review Comment:
We are in `rejoinShardLeaderElection`, I assumed we can ever enter in this
method for a PULL (or any non leader-eligible) replica, or can we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
