sigram commented on code in PR #2237:
URL: https://github.com/apache/solr/pull/2237#discussion_r1478749236
##########
solr/core/src/java/org/apache/solr/request/SolrRequestInfo.java:
##########
@@ -210,6 +217,12 @@ public void addCloseHook(Closeable hook) {
}
}
+ public QueryLimits getLimits() {
+ return req == null
+ ? QueryLimits.NONE
+ : (QueryLimits) req.getContext().computeIfAbsent(LIMITS_KEY, (k) ->
new QueryLimits(req));
Review Comment:
I think this is still incorrect... Since it uses the latest SRI from the
stack it will completely ignore the already existing QueryLimits created at the
bottom of the stack, and create a new instance to track just this part of the
processing - whereas we want to track the resource consumption across the whole
end-to-end request processing, beginning with the first SRI (at the bottom of
the stack) allocated to this query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
