sigram commented on code in PR #2237:
URL: https://github.com/apache/solr/pull/2237#discussion_r1478753833
##########
solr/core/src/java/org/apache/solr/request/SolrRequestInfo.java:
##########
@@ -75,6 +77,9 @@ public static void setRequestInfo(SolrRequestInfo info) {
} else if (stack.size() > MAX_STACK_SIZE) {
assert false : "SolrRequestInfo Stack is full";
log.error("SolrRequestInfo Stack is full");
+ } else if (!stack.isEmpty() && info.req != null) {
+ // if req is null limits will be an empty instance with no limits anyway.
Review Comment:
Maybe add a note that all SRI-s on the stack inherit the first instance of
the limits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
