gus-asf commented on code in PR #2237:
URL: https://github.com/apache/solr/pull/2237#discussion_r1486238725
##########
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##########
@@ -972,7 +978,8 @@ private DocSet getAndCacheDocSet(Query query) throws
IOException {
}
DocSet answer;
- if (SolrQueryTimeoutImpl.getInstance().isTimeoutEnabled()) {
+ SolrRequestInfo requestInfo = SolrRequestInfo.getRequestInfo();
+ if (requestInfo != null && requestInfo.getLimits().isTimeoutEnabled()) {
Review Comment:
in some cases there's an assert for requestInfo != null, rather than a null
check but that assert is not appropriate in all cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
