magibney commented on code in PR #2313:
URL: https://github.com/apache/solr/pull/2313#discussion_r1571142317
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -1017,19 +1023,21 @@ public String getBaseURL() {
}
private static class AsyncTracker {
- private static final int MAX_OUTSTANDING_REQUESTS = 1000;
+ private static final int DEFAULT_MAX_OUTSTANDING_REQUESTS = 1000;
Review Comment:
💯 -- it seems like this PR is motivated by a "custom solr client" use case?
But unless we make this configurable in a regular deployment (as would be
achieved by `EnvUtils`), there's no way to configure the clients that are used
for intra-cluster communication, which was the concern that initially motivated
the filing of SOLR-16932.
In fact, an `EnvUtils`-type approach was the _only_ approach taken in [the
patch we've been using to mitigate this issue
locally](https://github.com/cowpaths/fullstory-solr/pull/124).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
