pvcnt commented on code in PR #2313:
URL: https://github.com/apache/solr/pull/2313#discussion_r1573262174
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -1048,7 +1056,7 @@ private static class AsyncTracker {
int getMaxRequestsQueuedPerDestination() {
Review Comment:
This is used to set Jetty's `maxRequestsQueuedPerDestination`, which is
indeed per host. But the AsyncTracker itself has no per-host logic. However, it
depends in which context it is used. When used by the LbSolrClient (notably in
the context of the HttpShardHandler, but only when used directly by any
client), there is effectively one Http2SolrClient created per host, so this
matches. In other contexts, I believe there is a mismatch and it doesn't do
what it claims to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
