HoustonPutman commented on code in PR #2313:
URL: https://github.com/apache/solr/pull/2313#discussion_r1572832579
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -1048,7 +1056,7 @@ private static class AsyncTracker {
int getMaxRequestsQueuedPerDestination() {
Review Comment:
Yeah I'm pretty confused here why the async tracker would be a global queue,
and it's maximum is used to determine the max requests queued per destination?
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -1017,19 +1023,21 @@ public String getBaseURL() {
}
private static class AsyncTracker {
- private static final int MAX_OUTSTANDING_REQUESTS = 1000;
+ private static final int DEFAULT_MAX_OUTSTANDING_REQUESTS = 1000;
Review Comment:
That sounds good, but I'd remove the `solrj` part of the sys prop
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -1278,6 +1287,15 @@ public Builder withMaxConnectionsPerHost(int max) {
return this;
}
+ /**
+ * Specify the maximum number of concurrent asynchronous requests the
client can send. The
+ * default value is 1000
+ */
+ public Builder withMaxOutstandingRequests(int max) {
Review Comment:
well I don't think this is per-host. The Async tracker doesn't do any
per-host logic, does it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
