epugh commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1684536395
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##########
@@ -22,12 +22,7 @@
import java.io.IOException;
import java.lang.invoke.MethodHandles;
import java.time.Instant;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
+import java.util.*;
Review Comment:
I think we normally list every import!!!
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ClusterStateProvider.java:
##########
@@ -31,7 +29,7 @@
public interface ClusterStateProvider extends SolrCloseable {
static ClusterStateProvider newZkClusterStateProvider(
- Collection<String> zkHosts, String zkChroot, boolean canUseZkACLs) {
+ Collection<String> zkHosts, String zkChroot, boolean canUseZkACLs) {
Review Comment:
Run the Gradle tidy task to fix code formatting
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##########
@@ -1213,10 +1193,6 @@ protected DocCollection getDocCollection(String
collection, Integer expectedVers
// no such collection exists
return null;
}
- if (!ref.isLazilyLoaded()) {
Review Comment:
Any chance this
Ethos is now no longer used anywhere??
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##########
@@ -124,7 +119,10 @@ private ClusterState fetchClusterState(
throws SolrServerException, IOException, NotACollectionException {
ModifiableSolrParams params = new ModifiableSolrParams();
if (collection != null) {
+ log.debug("Making a call to Solr to fetch cluster state for collection:
", collection);
Review Comment:
Needs the if debug check...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
