dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1684977532
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##########
@@ -124,7 +124,14 @@ private ClusterState fetchClusterState(
throws SolrServerException, IOException, NotACollectionException {
ModifiableSolrParams params = new ModifiableSolrParams();
if (collection != null) {
+ if (log.isDebugEnabled()) {
+ log.debug("Making a call to Solr to fetch cluster state for
collection: {}", collection);
+ }
params.set("collection", collection);
+ } else {
+ if (log.isDebugEnabled()) {
+ log.debug("Making a call to Solr to fetch entire cluster state");
Review Comment:
From a performance perspective, I think requesting the entire state is
unacceptable. If we throw an UnsupportedOperationException here, what breaks?
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##########
@@ -1213,10 +1193,6 @@ protected DocCollection getDocCollection(String
collection, Integer expectedVers
// no such collection exists
return null;
}
- if (!ref.isLazilyLoaded()) {
Review Comment:
I don't know what that means, but any way, I find this aspect of the
PR/change most mysterious. It appears this check is an optimization. What
effect does removing it have?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
