dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1685215019
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##########
@@ -1213,10 +1193,6 @@ protected DocCollection getDocCollection(String
collection, Integer expectedVers
// no such collection exists
return null;
}
- if (!ref.isLazilyLoaded()) {
Review Comment:
> The CloudSolrClient only caches DocCollection instances where
ref.isLazilyLoaded() returns true. **However, for CollectionRef instances
handled by HTTP-based CSP, the default method CollectionRef.isLazilyLoaded()
returns false.** This PR disables the check in
CloudSolrClient.getDocCollection() to ensure caching works regardless of the
ref.isLazilyLoaded return value.
(I added emphasis). This is surprising.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
