timatbw commented on code in PR #2631:
URL: https://github.com/apache/solr/pull/2631#discussion_r1711372740
##########
solr/core/src/test/org/apache/solr/update/processor/SkipExistingDocumentsProcessorFactoryTest.java:
##########
@@ -314,6 +314,22 @@ public void
testSkippableUpdateIsSkippedIfSkipUpdatesTrue() throws IOException {
verify(next, never()).processAdd(cmd);
}
+ @Test
Review Comment:
True, these are pure unit tests, so we're not reliant on actual indexes and
calls to RTG code via static methods that we can't intercept during tests.
I guess this is the result of our internal testing strategies (pure unit
tests, plus docker-based full integration tests) but I'm happy to add real
index testing if there's a standard base test I should build on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
