epugh commented on code in PR #2631:
URL: https://github.com/apache/solr/pull/2631#discussion_r1711377616
##########
solr/core/src/test/org/apache/solr/update/processor/SkipExistingDocumentsProcessorFactoryTest.java:
##########
@@ -314,6 +314,22 @@ public void
testSkippableUpdateIsSkippedIfSkipUpdatesTrue() throws IOException {
verify(next, never()).processAdd(cmd);
}
+ @Test
Review Comment:
I think that if there are some good examples in
`SkipExistingDocumentsProcessorFactoryTest` that aren't mock, that you can use,
then great... However, if not, and these mocks do work, then thats fine.
Someday, I'd love to see some more comprehensive full integration tests
added to Solr... There are some BATS tests that start to approach that, but
we don't have consensus on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
