dsmiley commented on code in PR #2631:
URL: https://github.com/apache/solr/pull/2631#discussion_r1712549704
##########
solr/core/src/java/org/apache/solr/update/processor/SkipExistingDocumentsProcessorFactory.java:
##########
@@ -224,6 +224,17 @@ boolean doesDocumentExist(BytesRef indexedDocId) throws
IOException {
}
}
+ boolean doesChildDocumentExist(AddUpdateCommand cmd) throws IOException {
Review Comment:
> Does Solr typically put javadoc on non-public methods?
No. Add if you wish; if it'd be helpful. Based on what you said above; I
wouldn't!
I only use VisibleForTesting on a public method that is public only for
testing. Package scope is kinda whatever -- maybe assumed even.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
