epugh commented on code in PR #2703:
URL: https://github.com/apache/solr/pull/2703#discussion_r1756570707
##########
solr/bin/solr:
##########
@@ -1076,10 +1076,8 @@ if [ "${SOLR_HOME:0:${#EXAMPLE_DIR}}" = "$EXAMPLE_DIR"
]; then
SOLR_LOGS_DIR="$SOLR_HOME/../logs"
fi
-# Set the logging manager by default, so that Lucene JUL logs are included
with Solr logs.
-LOG4J_CONFIG=("-Djava.util.logging.manager=org.apache.logging.log4j.jul.LogManager")
if [ -n "${LOG4J_PROPS:-}" ]; then
- LOG4J_CONFIG+=("-Dlog4j.configurationFile=$LOG4J_PROPS")
+ LOG4J_CONFIG=("-Dlog4j.configurationFile=$LOG4J_PROPS")
fi
Review Comment:
Do we have a bats test that would catch the `LOG4J_CONFIG` not being
initialized and show if this is needed?
There is a lot of tricky logic in the start command, and I'd love to have
more tests so that as we refactor/change it we have more confidence that the
tests are meaningful!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
