szhou1998 commented on code in PR #2703:
URL: https://github.com/apache/solr/pull/2703#discussion_r1757550888
##########
solr/bin/solr:
##########
@@ -1076,10 +1076,8 @@ if [ "${SOLR_HOME:0:${#EXAMPLE_DIR}}" = "$EXAMPLE_DIR"
]; then
SOLR_LOGS_DIR="$SOLR_HOME/../logs"
fi
-# Set the logging manager by default, so that Lucene JUL logs are included
with Solr logs.
-LOG4J_CONFIG=("-Djava.util.logging.manager=org.apache.logging.log4j.jul.LogManager")
if [ -n "${LOG4J_PROPS:-}" ]; then
- LOG4J_CONFIG+=("-Dlog4j.configurationFile=$LOG4J_PROPS")
+ LOG4J_CONFIG=("-Dlog4j.configurationFile=$LOG4J_PROPS")
fi
Review Comment:
I added a commit to initialize LOG4J_CONFIG=() which is what it was
originally
https://github.com/apache/solr/pull/1765/files#diff-49c29c8f653341f48008c38f5f2cf970fa430cdca29181c819d7bdcfcc722980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
