dsmiley commented on code in PR #2786:
URL: https://github.com/apache/solr/pull/2786#discussion_r1809193371


##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -2061,13 +2066,16 @@ public void reload(String name, UUID coreId) {
           RefCounted<IndexWriter> iwRef = 
core.getSolrCoreState().getIndexWriter(null);
           if (iwRef != null) {
             IndexWriter iw = iwRef.get();
-            // switch old core to readOnly
-            core.readOnly = true;

Review Comment:
   I suppose doing this before was to protect changes happening after the 
commit sneaking it.  Why did you move it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to