bruno-roustant commented on code in PR #2786:
URL: https://github.com/apache/solr/pull/2786#discussion_r1810646341
##########
solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java:
##########
@@ -1115,4 +1117,23 @@ public CommitTracker getCommitTracker() {
public CommitTracker getSoftCommitTracker() {
return softCommitTracker;
}
+
+ /**
+ * The purpose of this {@link CommitUpdateCommand} extension is to indicate
that the {@link
+ * #commit(CommitUpdateCommand)} caller is closing the core and does not
want to open any
+ * searcher. Because even if {@link CommitUpdateCommand#openSearcher} is
false, a new real-time
+ * searcher will be opened with a standard {@link CommitUpdateCommand}. This
internal {@link
+ * ClosingCommitUpdateCommand} is a way to not add another public flag to
{@link
+ * CommitUpdateCommand}.
Review Comment:
I like this enum idea very much.
If we replace two public boolean fields by an enum field, would it be a
public API change, so limited to main branch?
Ideally, I would like to have this change in 9.x to get it in solr-sandbox.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
