dsmiley commented on code in PR #2786:
URL: https://github.com/apache/solr/pull/2786#discussion_r1811150504
##########
solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java:
##########
@@ -1115,4 +1117,23 @@ public CommitTracker getCommitTracker() {
public CommitTracker getSoftCommitTracker() {
return softCommitTracker;
}
+
+ /**
+ * The purpose of this {@link CommitUpdateCommand} extension is to indicate
that the {@link
+ * #commit(CommitUpdateCommand)} caller is closing the core and does not
want to open any
+ * searcher. Because even if {@link CommitUpdateCommand#openSearcher} is
false, a new real-time
+ * searcher will be opened with a standard {@link CommitUpdateCommand}. This
internal {@link
+ * ClosingCommitUpdateCommand} is a way to not add another public flag to
{@link
+ * CommitUpdateCommand}.
Review Comment:
Definitely merely an internal change in terms of just the
CommitUpdateCommand internals (I'm aware its fields are all public :-(. No
backwards-compatibility concern.
Of course users could pass those booleans at an HTTP params level and it
still needs to work, ultimately being converted to the appropriate enum. Not
sure if you want to add a new http param for the enum as an alternative... I
suppose you might.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
