jdyer1 commented on code in PR #2805:
URL: https://github.com/apache/solr/pull/2805#discussion_r1820883475
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/LBHttp2SolrClientIntegrationTest.java:
##########
@@ -337,8 +349,27 @@ public void startJetty() throws Exception {
fail("TESTING FAILURE: could not grab requested port.");
}
this.port = newPort;
- // System.out.println("waiting.........");
- // Thread.sleep(5000);
+ }
+ }
+
+ private static class LBClientHolder implements AutoCloseable {
Review Comment:
Well, looking at LBSolrClient#close (from 2018) -- from which all 3
implementations inherit -- it doesn't seem to. And before I modified this
test, it had both the inner and outer clients in the autoclosable try/catch. I
agree that this seems wrong and perhaps was an oversight long ago. But then
again, because we make the user create their own inner client as a separate
step, perhaps it was thought it is the opener's responsibility to explicitly
close.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
