dsmiley commented on code in PR #2805:
URL: https://github.com/apache/solr/pull/2805#discussion_r1821213402
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/LBHttp2SolrClientIntegrationTest.java:
##########
@@ -337,8 +349,27 @@ public void startJetty() throws Exception {
fail("TESTING FAILURE: could not grab requested port.");
}
this.port = newPort;
- // System.out.println("waiting.........");
- // Thread.sleep(5000);
+ }
+ }
+
+ private static class LBClientHolder implements AutoCloseable {
Review Comment:
> we make the user create their own inner client as a separate step, perhaps
it was thought it is the opener's responsibility to explicitly close
Ah; okay that makes sense; I didn't look previously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
