jdyer1 commented on PR #2805: URL: https://github.com/apache/solr/pull/2805#issuecomment-2447614530
I am torn about what to do about the lengthy doc-comment which was copy/pasted from `LBHttpSolrClient` to `LBHttp2SolrClient`. I suppose the right thing to do at this point is to copy/paste it once again for `LBHttpJdkSolrClient`, and not to have anything elaborate in the abstract class doc-comment. This is yet another argument for having a generic LB Client and not subclasses, but I also feel this is beyond the scope of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
