pvcnt commented on code in PR #2913:
URL: https://github.com/apache/solr/pull/2913#discussion_r1896798141
##########
solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java:
##########
@@ -160,28 +156,13 @@ protected String getCoreOrColName() {
return collectionName;
}
- public static SolrQueryRequest wrappedReq(
- SolrQueryRequest delegate, String collectionName, HttpSolrCall
httpSolrCall) {
- Properties p = new Properties();
- if (collectionName != null) {
- p.put(CoreDescriptor.CORE_COLLECTION, collectionName);
- }
- p.put(CloudDescriptor.REPLICA_TYPE, Replica.Type.PULL.toString());
- p.put(CoreDescriptor.CORE_SHARD, "_");
+ public static SolrQueryRequest wrappedReq(SolrQueryRequest delegate,
HttpSolrCall httpSolrCall) {
Review Comment:
Oh, I think I eventually got it! With coordinator nodes, there is a single
synthetic core created per config set, hence service multiple collections. This
method is here so make it able to serve different collections by injecting an
ad-hoc cloud descriptor. However, this seems like a very dodgy pattern, as
calls going to `getCore().getCoreDescriptor().getCloudDescriptor()` would not
work.
Test `TestCoordinatorRole#testMultiCollectionMultiNode` is supposed to test
this scenario though, I do not understand, if my hypothesis is correct, how it
can still pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
